Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(field): remove the need for wrapper:false in createField #229

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

EdieLemoine
Copy link
Contributor

No description provided.

@myparcel-bot myparcel-bot bot added the approved (Auto) label Jan 10, 2024
@EdieLemoine EdieLemoine enabled auto-merge January 10, 2024 14:04
@myparcel-bot myparcel-bot bot force-pushed the fix/fix-remove-wrapper-false branch from 109b6e9 to 4ef80f2 Compare January 10, 2024 14:05
@EdieLemoine EdieLemoine force-pushed the fix/fix-remove-wrapper-false branch from 4ef80f2 to 43b320d Compare January 10, 2024 14:06
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (550ec98) 85.79% compared to head (43b320d) 85.72%.

Files Patch % Lines
libs/core/src/utils/createField.ts 50.00% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #229      +/-   ##
==========================================
- Coverage   85.79%   85.72%   -0.07%     
==========================================
  Files          48       48              
  Lines        2154     2158       +4     
  Branches      206      208       +2     
==========================================
+ Hits         1848     1850       +2     
  Misses        105      105              
- Partials      201      203       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine disabled auto-merge January 10, 2024 16:55
@EdieLemoine EdieLemoine enabled auto-merge January 10, 2024 16:56
@EdieLemoine EdieLemoine added this pull request to the merge queue Jan 10, 2024
Merged via the queue into beta with commit 86aa72c Jan 10, 2024
5 of 6 checks passed
@EdieLemoine EdieLemoine deleted the fix/fix-remove-wrapper-false branch January 10, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

4 participants