Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(field): remove fields from the form when unmounted #233

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Cysword
Copy link
Contributor

@Cysword Cysword commented Jan 25, 2024

No description provided.

@Cysword Cysword requested review from a team as code owners January 25, 2024 14:42
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ec08fc3) 85.50% compared to head (efe6654) 85.65%.

Files Patch % Lines
libs/core/src/utils/createField.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #233      +/-   ##
==========================================
+ Coverage   85.50%   85.65%   +0.14%     
==========================================
  Files          48       48              
  Lines        2167     2175       +8     
  Branches      210      213       +3     
==========================================
+ Hits         1853     1863      +10     
+ Misses        109      104       -5     
- Partials      205      208       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the fix/resolve-unmounted-fields branch 3 times, most recently from 865c63a to 6bd45bd Compare January 25, 2024 15:41
@EdieLemoine EdieLemoine enabled auto-merge January 25, 2024 15:42
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jan 25, 2024
@EdieLemoine EdieLemoine changed the title fix: remove fields from the form when unmounted fix(field): remove fields from the form when unmounted Jan 25, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/resolve-unmounted-fields branch 2 times, most recently from 2a05e53 to 21bba71 Compare January 25, 2024 16:02
@Cysword Cysword force-pushed the fix/resolve-unmounted-fields branch from 21bba71 to 03476e3 Compare January 26, 2024 15:23
@EdieLemoine EdieLemoine added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/resolve-unmounted-fields branch from 03476e3 to efe6654 Compare February 2, 2024 10:13
@EdieLemoine EdieLemoine merged commit 8aa462c into beta Feb 7, 2024
5 checks passed
@EdieLemoine EdieLemoine deleted the fix/resolve-unmounted-fields branch February 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants