-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix setting ref values and pass down slots and attrs #250
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4878c5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## beta #250 +/- ##
==========================================
+ Coverage 60.75% 60.98% +0.23%
==========================================
Files 94 95 +1
Lines 1873 1902 +29
Branches 251 256 +5
==========================================
+ Hits 1138 1160 +22
- Misses 490 492 +2
- Partials 245 250 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is dit een fix of echt een feature? titel is ook veel te lang
Add a method to add errors to a field
Add method to set a field to
isValid === false
Update methods to also handle when the values are not refs anymore
Add support for fields to inherit passed attributes and slots