Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix setting ref values and pass down slots and attrs #250

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

Cysword
Copy link
Contributor

@Cysword Cysword commented Oct 2, 2024

Add a method to add errors to a field
Add method to set a field to isValid === false
Update methods to also handle when the values are not refs anymore
Add support for fields to inherit passed attributes and slots

@Cysword Cysword requested review from a team as code owners October 2, 2024 09:52
Copy link

nx-cloud bot commented Oct 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4878c5f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 77.19298% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.98%. Comparing base (1b5225e) to head (4878c5f).
Report is 2 commits behind head on beta.

Files with missing lines Patch % Lines
libs/core/src/form/Field.ts 78.12% 0 Missing and 7 partials ⚠️
libs/core/src/utils/updateMaybeRef.ts 50.00% 2 Missing and 2 partials ⚠️
libs/core/src/utils/createField.ts 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #250      +/-   ##
==========================================
+ Coverage   60.75%   60.98%   +0.23%     
==========================================
  Files          94       95       +1     
  Lines        1873     1902      +29     
  Branches      251      256       +5     
==========================================
+ Hits         1138     1160      +22     
- Misses        490      492       +2     
- Partials      245      250       +5     
Flag Coverage Δ
unit 60.98% <77.19%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libs/core/src/form/Field.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is dit een fix of echt een feature? titel is ook veel te lang

libs/core/src/form/Field.ts Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Oct 3, 2024
@Cysword Cysword changed the title feat: add support to handle the values when unwrapped and for passed slots and attributes from the template feat: handle MaybeRef values and pass down slots and attributes Oct 3, 2024
@Cysword Cysword requested a review from EdieLemoine October 3, 2024 10:16
@Cysword Cysword changed the title feat: handle MaybeRef values and pass down slots and attributes fix: handle MaybeRef values and pass down slots and attributes Oct 3, 2024
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Oct 3, 2024
@EdieLemoine EdieLemoine changed the title fix: handle MaybeRef values and pass down slots and attributes fix: fix setting ref values and pass down slots and attrs Oct 3, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Oct 3, 2024
Merged via the queue into beta with commit 2ada725 Oct 3, 2024
13 checks passed
@EdieLemoine EdieLemoine deleted the feat/add-support-for-non-refs branch October 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants