Use Github action arm runner for aarch64 builds #89
+4
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdce8p
force-pushed
the
github-arm-runners
branch
from
bea3e6b to
1302f1d
Compare
cdce8p
force-pushed
the
github-arm-runners
branch
from
525ba11 to
87ed858
Compare
hauntsaninja
approved these changes
Jan 16, 2025
.github/workflows/build.yml
Outdated
| @@ -39,7 +41,7 @@ jobs: | |||
| ) | |||
| echo "include=$MATRIX" | tee -a $GITHUB_OUTPUT | |||
| env: | |||
| CIBW_ARCHS_LINUX: x86_64 aarch64 | |||
| CIBW_ARCHS_LINUX: x86_64 | |||
There was a problem hiding this comment.
nit: should we remove this from here and move --archs x86_64 into the cibuildwheel command above?
|
Sick, looks like the tests run >2x faster on these arm runners than they do on the x86 runners. Maybe we should switch mypy CI to run on the arm runners too... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github just made
arm64runners available for public preview 🎉https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/