Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves accessibility of link and fake link elements #5184

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Sep 23, 2024

Fixes: https://github.com/mysociety/societyworks/issues/4538

The styling is based on the GOVUK links

Pending:

  • Test cobrands now that I have added variables for the header there is some tidy up to do, we want cobrands navbars to look just like they did before this PR.
  • Get rid of text-decoration on sticky-sidebar sticky-sidebar--help
Screenshot 2024-09-23 at 13 16 54

[skip changelog]

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (2402023) to head (f15f3ee).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5184      +/-   ##
==========================================
+ Coverage   82.47%   82.66%   +0.19%     
==========================================
  Files         406      406              
  Lines       31721    32105     +384     
  Branches     5045     5205     +160     
==========================================
+ Hits        26161    26540     +379     
- Misses       4069     4070       +1     
- Partials     1491     1495       +4     
Flag Coverage Δ
82.66% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant