Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gloucester] Added cobrand front-end #5295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Dec 10, 2024

Fixes: https://github.com/mysociety/societyworks/issues/4610

It includes:

  • Logos
  • Fonts
  • Emails
  • Colours
  • Navigation bar
  • favicon
  • Site message

Desktop

Screen.Recording.2024-12-10.at.10.40.57.mov
Screen.Recording.2024-12-10.at.10.41.28.mov
Screen.Recording.2024-12-10.at.10.41.55.mov

Mobile

Screen.Recording.2024-12-10.at.10.47.12.mov

Emails

Screenshot 2024-12-10 at 10 42 38 Screenshot 2024-12-10 at 10 43 10

[skip changelog]

It includes

- Logos
- Fonts
- Emails
- Colours
- Navigation bar
- favicon
- Site message
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 16.00000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (0d4d098) to head (8a0a706).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Gloucester.pm 16.00% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5295      +/-   ##
==========================================
- Coverage   82.34%   82.24%   -0.10%     
==========================================
  Files         413      414       +1     
  Lines       32719    32769      +50     
  Branches     5241     5249       +8     
==========================================
+ Hits        26942    26952      +10     
- Misses       4225     4266      +41     
+ Partials     1552     1551       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucascumsille
Copy link
Contributor Author

Hi @chrismytton just in case I deleted most of the files that are not yet necessary, but I didn't delete the following:

  • assets,js
  • tracking_code.html
  • footer_extra_js.html

Those ones have the same info as Gloucestershire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant