[ZA] Quick fixes for Province page tab styling #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests were failing because they were doing the following assertion: self.assertContains(resp, "There are 3 people related to Test Place.")I've removed those assertions now, so going to wait for Travis to run the tests before I review this. |
|
@chrismytton Tests pass! |
zarino
force-pushed
the
2475-za-simplify-province-pages
branch
from
da5de5a to
886eca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out combining the /place/<name> and /place/<name>/places views was trickier than anticipated.
So while I wait for @chrismytton to find some time for that, here’s a super quick fix for the broken tab styling and extraneous membership total that the PMG folks wanted fixed as part of #2475.