run tests against MySQL 5.6 #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingingBush
force-pushed
the
build/mysql_5.6
branch
from
5758a3e to
9ec450a
Compare
|
Needs a copy-paste from the new integration targets. |
SingingBush
force-pushed
the
build/mysql_5.6
branch
from
9ec450a to
5ee9ce2
Compare
|
How do we specify that it's OK if it fails? I don't mind testing against 5.6, but I don't want it to prevent progress. |
|
There is continue-on-error. To be fair though I'm not bothered about checking mysql 5.6, only pushed this in case it was considered helpful to someone. Am happy to also close the PR, the builds are already fairly robust |
|
What if we split this into its own workflow yaml file? That way at least it will not show that integration tests failed if the 5.6 runs failed? Then we can at least easily turn it off if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you'd want to run mysql-native against MySQL 5.6 as well but thought I'd add it just in case. Feel free to decline this one. I don't have a need for it.