[#112] FileSystem, Command 모킹 구현 및 executor 테스트 환경 작성 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 14 days for rrdb:
|
|
✅ Total Coverage: 38.14% |
myyrakle
changed the title
|
✅ Total Coverage: 39.40% |
myyrakle
commented
Jul 4, 2024
|
|
||
| pub struct Executor { | ||
| pub(crate) config: Arc<GlobalConfig>, | ||
| pub(crate) file_system: Arc<dyn FileSystem + Send + Sync>, | ||
| pub(crate) command_runner: Arc<dyn CommandRunner + Send + Sync>, |
|
|
||
| #[cfg(target_os = "linux")] | ||
| #[tokio::test] | ||
| async fn test_init_config() { |
| @@ -32,7 +32,8 @@ async fn main() -> Result<(), RRDBError> { | |||
|
|
|||
| let executor = Executor::new(Arc::new(config)); | |||
|
|
|||
| executor.init().await?; | |||
| executor.init_config().await?; | |||
| executor.init_database().await?; | |||
There was a problem hiding this comment.
쿼리랑 초기화가 좀 섞여있으니까 어지러워서 분리함
There was a problem hiding this comment.
이니셜라이저와 query executor를 분리해서 관리해야하나 하는 생각도...
|
✅ Total Coverage: 39.40% |
DPS0340
reviewed
Jul 5, 2024
Comment on lines
+21
to
+36
|
|
||
| #[cfg(target_os = "linux")] | ||
| pub const SYSTEMD_DAEMON_SCRIPT: &str = r#"[Unit] | ||
| Description=RRDB | ||
|
|
||
| [Service] | ||
| Type=simple | ||
| Restart=on-failure | ||
| ExecStart=/usr/bin/rrdb run | ||
| RemainAfterExit=on | ||
| User=root | ||
| StandardOutput=file:/var/log/rrdb.stdout.log | ||
| StandardError=file:/var/log/rrdb.stderr.log | ||
|
|
||
| [Install] | ||
| WantedBy=multi-user.target"#; |
There was a problem hiding this comment.
macos도 비슷한 pub const 상수 만드는게 좋을까요?
DPS0340
added a commit
that referenced
this pull request
Jul 5, 2024
DPS0340
added a commit
that referenced
this pull request
Jul 5, 2024
DPS0340
added a commit
that referenced
this pull request
Jul 5, 2024
DPS0340
added a commit
that referenced
this pull request
Jul 5, 2024
DPS0340
added a commit
that referenced
this pull request
Jul 5, 2024
DPS0340
added a commit
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #112
설명
executor 수준의 단위테스트 작성을 위한 모킹 구조 추가