Don't update reports on pages containing {{database report}} #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'm totally supportive of the effort to move to |
|
Yes, I suppose you are right to look for {{database report}} explicitly rather than go via {{nobots}}, so that it's less hacky from an on-wiki perspective. Updated. |
fee1-dead
requested changes
Sep 27, 2024
legoktm
changed the title
|
Thanks :) let's give it a shot |
legoktm
approved these changes
Sep 30, 2024
|
Hmm, I think we need @fee1-dead to also approve (or remove the requested changes). |
fee1-dead
approved these changes
Sep 30, 2024
|
OK, should be deployed now and I added logging in a follow-up PR so we can remove migrated reports from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal support for skipping pages containing {{nobots}}. Only pages with the exact string are skipped for now.
This enables community members to replace broken reports with ones based on {{Database report}}, without having to worry about the bot eventually overwriting the migrated (and possibly improved) queries. {{Database report}} makes the SQL community-controlled, making it easy to fix and enhance. The bot which updates the template-based reports doesn't honor {{nobots}}.