show-alpha attribute #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simshaun
commented
Aug 8, 2024
| @@ -180,7 +183,7 @@ class ColorPicker extends HTMLElement { | |||
| const scope = this; | |||
| this.state = new Proxy(scope.stateDefaults, { | |||
| // eslint-disable-next-line | |||
| set(target: IColorPickerState, key: string | symbol, value: any, _receiver: any): boolean { | |||
| set(target: IColorPickerState, key: keyof IColorPickerState, value: any, _receiver: any): boolean { | |||
There was a problem hiding this comment.
This is an unrelated change but protects against using an invalid key name below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for this library. I'm swapping out a heavier color picker library for this one and need the ability to hide the alpha controls.
This PR allows for that by introducing a
show-alphaattribute. (defaults to true to protect backwards-compatibility)