Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] make netsim run from examples #2959

Draft
wants to merge 3 commits into
base: refactor-drop-external-protocols
Choose a base branch
from

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Nov 22, 2024

Description

Moves our netsim tests to run from an example and only test the lib part of the code, not the full CLI & blobs.

Things left to do:

  • rename the example from new to anything that makes more sense netsim runs it under iroh-transfer
  • clean up the example code
  • add the option to provide either a relay config or pass in at least the relay url as an argument
  • continue the CI adjustment and move all invocations of the netsim runner to run from iroh_v2 and integration_v2 sims (we want a less abrupt netsim switchover)
  • convert the remaining sims in chuck/netsim/sims to the new format
  • after some time flip back the CI invocations to be regular iroh and integration sims which includes doing the same on netsim and removing the old ones

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Arqu Arqu self-assigned this Nov 22, 2024
@Arqu Arqu changed the base branch from main to refactor-drop-external-protocols November 22, 2024 11:35
@Arqu Arqu changed the title Arqu/netsim from example [WIP] make netsim run from examples Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2959/docs/iroh/

Last updated: 2024-11-22T13:12:28Z

Copy link

github-actions bot commented Nov 22, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 9684f2e

@Arqu
Copy link
Collaborator Author

Arqu commented Nov 22, 2024

test case throughput_gbps throughput_transfer
iroh 1_to_1 1.32 1.33
iroh 1_to_3 4.28 4.28
iroh 1_to_5 6.89 6.90
iroh 1_to_10 11.65 11.67
iroh 2_to_2 2.77 2.78
iroh 2_to_4 5.42 5.43
iroh 2_to_6 8.22 8.23
iroh 2_to_10 13.55 13.58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant