-
Notifications
You must be signed in to change notification settings - Fork 3
fix: remove Netlink error variant for Android #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove Netlink error variant for Android #17
Conversation
This fixes compilation of Delta Chat in debug mode for Android 5 (API level 21) using NDK 27. Without this change symbols like `process_vm_writev` which are not actually used are pulled in and break linking step. They are only optimized out in release mode. See <chatmail/core#6687> for details.
41d6d8b
to
315726a
Compare
CI is testing the build for Android, but not the linking of any binary, maybe that is why it was not detected. |
I thought our CI was compiling for android? We need to figure out why that wasn't working. |
hmm, not sure this is the right fix, |
The problem is not that it does not compile, but that exporting an error variant from a crate results in the compiler including unused unrelated functions from |
CI runs |
I don't think there is a proper fix - sufficiently dumb compiler can throw the whole libc in without removing any unused symbols and then it will not link. But at least this change fixes our setup for now. |
the state of (handling) android is horrible, so if this works, lets just use it for now |
This fixes compilation of Delta Chat
in debug mode
for Android 5 (API level 21) using NDK 27.
Without this change symbols like
process_vm_writev
which are notactually used are pulled in
and break linking step.
They are only optimized out
in release mode.
See chatmail/core#6687
for details.