Skip to content

chore: fix minimal crates and update igd-next #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

dignifiedquire
Copy link
Contributor

Copy link

github-actions bot commented Apr 3, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/19/docs/iroh_gossip/

Last updated: 2025-04-03T13:20:55Z

@n0bot n0bot bot added this to iroh Apr 3, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Apr 3, 2025
@dignifiedquire
Copy link
Contributor Author

@link2xt I am trying to reduce the chaos that is rtnetlink, could you check if this version still works for you?

release-arch: aarch64
runner: [self-hosted, macOS, ARM64]
steps:
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an ancient version of the checkout action that's probably deprecated. Please use @v4.

Cargo.toml Outdated
@@ -37,3 +37,6 @@ unexpected_cfgs = { level = "warn", check-cfg = ["cfg(iroh_docsrs)"] }

[workspace.lints.clippy]
unused-async = "warn"

[patch.crates-io]
n0-future = { git = "https://github.com/n0-computer/n0-future", branch = "minimal-versions" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be removed before merging

link2xt added a commit to chatmail/core that referenced this pull request Apr 7, 2025
@link2xt
Copy link
Contributor

link2xt commented Apr 7, 2025

This at least compiles in chatmail/core#6687
I tested than I can build Android application with this change.

I also tested that backup transfer works.

@dignifiedquire
Copy link
Contributor Author

thanks @link2xt that's great news, as this means we can stop carrying two different versions of netlink

@dignifiedquire
Copy link
Contributor Author

This is currently blocked on a release of rust-netlink/netlink-packet-route#161 to restore android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants