Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the big code_80091750.c rename #684

Merged
merged 48 commits into from
Jan 4, 2025
Merged

the big code_80091750.c rename #684

merged 48 commits into from
Jan 4, 2025

Conversation

coco875
Copy link
Contributor

@coco875 coco875 commented Sep 17, 2024

No description provided.

@coco875 coco875 marked this pull request as draft September 17, 2024 07:44
@coco875 coco875 changed the title some rename some rename in code_80091750.c Sep 22, 2024
@coco875
Copy link
Contributor Author

coco875 commented Sep 27, 2024

between func_800A66A8 and func_800AC458 there is a rodata of a function who are not valid

@coco875
Copy link
Contributor Author

coco875 commented Sep 27, 2024

around 0x800f24a0

@coco875
Copy link
Contributor Author

coco875 commented Sep 27, 2024

ok it's in func_800A7A4C

@coco875 coco875 changed the title some rename in code_80091750.c the big code_80091750.c rename Oct 6, 2024
coco875
coco875 commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author

@coco875 coco875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks AloXado320 to get so much function match

@coco875
Copy link
Contributor Author

coco875 commented Oct 7, 2024 •
edited
Loading

stat:
93.64% Complete
GLOBAL_ASM remaining: 48
NON_MATCHING remaining: 44
MIPS_TO_C remaining: 1

@Tmcg2 Tmcg2 mentioned this pull request Oct 7, 2024
Open
@MegaMech
Copy link
Collaborator

Rename menu_item.c to menu_items.c

@MegaMech
Copy link
Collaborator

MegaMech commented Dec 31, 2024 •
edited
Loading

load_menu_item_ui --> add_ui_item

@MegaMech
Copy link
Collaborator

load_menus --> setup_menus

@MegaMech
Copy link
Collaborator

render_player_time --> render_lap_times

@MegaMech
Copy link
Collaborator

render_texture_rectangle_from_base --> render_texture_rectangle_wrap

@MegaMech
Copy link
Collaborator

gGameLogoAddress --> something else

@MegaMech
Copy link
Collaborator

MegaMech commented Dec 31, 2024 •
edited
Loading

image
These don't follow the naming convention @AloXado320

These variables are not global. They're segmented.

seg2_copyright_1996_texture
seg2_push_start_button_texture
seg2_game_select_texture
seg2_menu_1p_column
seg2_menu_2p_column
seg2_menu_3p_column
seg2_menu_4p_column
seg2_50_CC_texture
seg2_100_CC_texture
seg2_150_CC_texture
seg2_extra_CC_texture
seg2_menu_no_item_texture
seg2_data_texture
seg2_P1_border_texture
seg2_P2_border_texture
seg2_P3_border_texture
seg2_P4_border_texture
seg2_menu_select_texture
seg2_mushroom_cup_texture
seg2_flower_cup_texture
seg2_star_cup_texture
seg2_special_cup_texture
seg2_mario_raceway_preview_small_texture
seg2_mushroom_cup_title_texture
seg2_flower_cup_title_texture
seg2_star_cup_title_texture
seg2_special_cup_title_texture
seg2_battle_title_texture
seg2_mario_raceway_title_texture
seg2_choco_mountain_title_texture

MegaMech
MegaMech requested changes Dec 31, 2024
View reviewed changes
src/ending/credits.c Outdated Show resolved Hide resolved
src/ending/credits.c Outdated Show resolved Hide resolved
src/save.c Outdated
@@ -427,21 +427,21 @@ u8 func_800B5508(s32 cup, s32 ccGrandPrixPoints, s32 points_scored) {

// Check if all 4 cups have gold cups scored
// for a given CC mode
s32 func_800B5530(s32 cc_mode) {
bool has_terminate_cc_mode(s32 cc_mode) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_cc_mode_complete

MegaMech
MegaMech requested changes Dec 31, 2024
View reviewed changes
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
@MegaMech
Copy link
Collaborator

image
Just an extra nitpick.

Could you please label the VERSUS and BATTLE here?

Should be able to find by searching CurrentRaceRankByPlayerId[type - MENU_ITEM_TYPE_0B1] != 0) {

MegaMech
MegaMech requested changes Jan 1, 2025
View reviewed changes
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
src/menu_items.c Outdated Show resolved Hide resolved
@MegaMech
Copy link
Collaborator

MegaMech commented Jan 1, 2025

Fix the enums in the menu_items header so they follow convention BLAHpriority BLAH_PRIORITY

@coco875 coco875 mentioned this pull request Jan 2, 2025
Merged
@MegaMech
Copy link
Collaborator

MegaMech commented Jan 2, 2025

unref_800E86E0

unref_D_800E86E0

@MegaMech MegaMech merged commit 5e1ce53 into n64decomp:master Jan 4, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaMech MegaMech MegaMech requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coco875 @MegaMech @AloXado320