Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Microsoft Entra ID Node): New node #11779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

feelgood-interface
Copy link
Contributor

@feelgood-interface feelgood-interface commented Nov 18, 2024

Summary

Add new Microsoft Entra node (Azure Active Directory).

Remarks about the node that need to be considered:

  1. The scope includes Sites.FullControl.All which was the only way I was able to update the user's personal details How to update hiredate and birthday using Graph .NET SDK microsoftgraph/msgraph-sdk-dotnet#1316. It might be a good idea to replace the scopes with the .default scope.
  2. The filter query can be improved with filter type-key-value collection, if required.
  3. I added loadOptions for select properties. This is not the most elegant way; it could also just be replaced by a static array.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@feelgood-interface feelgood-interface changed the title feat(Microsoft Entra): Add microsoft entra node feat(Microsoft Entra Node): New node Nov 18, 2024
@feelgood-interface feelgood-interface changed the title feat(Microsoft Entra Node): New node feat(Microsoft Entra ID Node): New node Nov 18, 2024
@n8n-assistant n8n-assistant bot added community Authored by a community member core Enhancement outside /nodes-base and /editor-ui node/improvement New feature or request node/new Creation of an entirely new node in linear Issue or PR has been created in Linear for internal review labels Nov 18, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 18, 2024

Hey @feelgood-interface,

Thanks for the PR, We have created "GHC-458" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member core Enhancement outside /nodes-base and /editor-ui in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request node/new Creation of an entirely new node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants