Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Drop response wrapper requirement from Subworkflow Tool output #11785

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CharlieKolb
Copy link
Contributor

Summary

Based on @OlegIvaniv 's work.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2861/feature-remove-the-field-to-return-from-the-workflow-tool-node

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@CharlieKolb CharlieKolb marked this pull request as ready for review November 19, 2024 10:06
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Nov 19, 2024
@@ -200,6 +200,11 @@ export class ToolWorkflow implements INodeType {
hint: 'The field in the last-executed node of the workflow that contains the response',
description:
'Where to find the data that this tool should return. n8n will look in the output of the last-executed node of the workflow for a field with this name, and return its value.',
displayOptions: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please advise whether this is the proper way to handle this

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...hain/nodes/tools/ToolWorkflow/ToolWorkflow.node.ts 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants