Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MongoDB Node): Fix typo in variable name (no-changelog) #11791

Merged

Conversation

my-opencode
Copy link
Contributor

Summary

No associated issue.
Renamed scoped const from "preperedItems" to "preparedItems" inside the prepareItems function.

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Nov 19, 2024
@Joffcom
Copy link
Member

Joffcom commented Nov 19, 2024

Hey @my-opencode,

Thanks for the PR, We have created "GHC-462" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@Joffcom Joffcom changed the title fix(core): Nodes > Mongo > Generics > Variable name typo fix(MongoDB Node): Fix typo in variable name (no-changelog) Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...kages/nodes-base/nodes/MongoDb/GenericFunctions.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally don't accept PRs like this but we will let this one through.

@Joffcom Joffcom merged commit bc0d51e into n8n-io:master Nov 22, 2024
18 checks passed
@janober
Copy link
Member

janober commented Nov 27, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants