-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): Mark deprecations for v2 #11817
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea to make it its own service 👏 Some comments about wording mainly
@tomi Love your feedback as always! Please have another check when you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
n8n Run #8034
Run Properties:
|
Project |
n8n
|
Branch Review |
mark-deprecations-v2
|
Run status |
Passed #8034
|
Run duration | 04m 38s |
Commit |
e55bae18cc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
|
Committer | Iván Ovejero |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
0
|
Skipped |
0
|
Passing |
478
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Summary
Mark deprecations for
N8N_BINARY_DATA_TTL
,N8N_PERSISTED_BINARY_DATA_TTL
,EXECUTIONS_DATA_PRUNE_TIMEOUT
,N8N_BINARY_DATA_MODE
as'default'
,N8N_CONFIG_FILES
,DB_TYPE
asmysqldb
ormariadb
,N8N_PATH
,N8N_SKIP_WEBHOOK_DEREGISTRATION_SHUTDOWN
, and--tunnel
.See warning in regular logs and in debug logs.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)