Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix AI assistant loading message layout #11819

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

Fixes a layout bug where AI Assistant loading message overlaps other messages:
image

cstuncsik
cstuncsik previously approved these changes Nov 21, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 21, 2024
Copy link
Contributor

Copy link

cypress bot commented Nov 21, 2024

n8n    Run #8037

Run Properties:  status check passed Passed #8037  •  git commit 12397a5ff2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review fix-assistant-layout
Run status status check passed Passed #8037
Run duration 04m 34s
Commit git commit 12397a5ff2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

cstuncsik
cstuncsik previously approved these changes Nov 21, 2024
Copy link
Contributor

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/components/AskAssistantChat/AskAssistantChat.vue 98.36% 2 Missing ⚠️
...nents/AskAssistantChat/AskAssistantChat.stories.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cstuncsik
cstuncsik previously approved these changes Nov 21, 2024
Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 89b4807 into master Nov 22, 2024
37 of 39 checks passed
@MiloradFilipovic MiloradFilipovic deleted the fix-assistant-layout branch November 22, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants