feat(core): Shut down runner on idle timeout (no-changelog) #11820
+146
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
commented
Nov 21, 2024
packages/@n8n/task-runner/src/js-task-runner/__tests__/js-task-runner.test.ts
Show resolved
Hide resolved
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
tomi
reviewed
Nov 21, 2024
packages/@n8n/task-runner/src/js-task-runner/__tests__/js-task-runner.test.ts
Show resolved
Hide resolved
|
Edit: Looks like it's covered already in the launcher |
ivov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exit the runner if idle for longer than
N8N_RUNNERS_IDLE_TIMEOUTseconds inexternalmode. Launcher will later re-launch runner on demand.To be reviewed together with: n8n-io/task-runner-launcher#13
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2246
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)