Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Bring back execution data on the executionFinished push message #11821

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 21, 2024

Summary

We removed the full execution data from the payload for executionFinished push message in #11703, because that serialization sometimes required quite a lot of memory.
This PR "temporarily" brings that data back, but now we instead serialize the data using flatted.stringify instead of JSON.stringify, which is a lot less expensive.

This change is still temporary, as we should instead improve the state management in the frontend to construct the final execution data based on all the partial data already delivered in the nodeExecuteAfter push messages.

Related Linear tickets, Github issues, and Community forum posts

PAY-2270

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 21, 2024
@netroy netroy force-pushed the PAY-2270-temporary-fix branch 4 times, most recently from 4ffa63a to f867412 Compare November 21, 2024 12:23
@netroy netroy added the release/backport Changes that need to be backported to older releases. label Nov 21, 2024
r00gm
r00gm previously approved these changes Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ges/editor-ui/src/composables/usePushConnection.ts 47.05% 9 Missing ⚠️
...ckages/cli/src/workflow-execute-additional-data.ts 16.66% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

despairblue
despairblue previously approved these changes Nov 21, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 21, 2024

n8n    Run #8058

Run Properties:  status check failed Failed #8058  •  git commit 03135702f1: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project n8n
Branch Review master
Run status status check failed Failed #8058
Run duration 04m 19s
Commit git commit 03135702f1: 🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 434
View all changes introduced in this branch ↗︎

Tests for review

Failed  17-sharing.cy.ts • 1 failed test

View Output Video

Test Artifacts
Credential Usage in Cross Shared Workflows > should only show credentials in their personal project for members if the workflow was shared with them Test Replay Screenshots Video
Failed  8-http-request-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  39-import-workflow.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  2372-ado-prevent-clipping-params.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  1858-PAY-can-use-context-menu.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 23 specs in Cypress Cloud.

r00gm
r00gm previously approved these changes Nov 22, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 0313570 into master Nov 22, 2024
36 checks passed
@netroy netroy deleted the PAY-2270-temporary-fix branch November 22, 2024 18:09
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
@janober
Copy link
Member

janober commented Nov 25, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants