-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Bring back execution data on the executionFinished
push message
#11821
Conversation
4ffa63a
to
f867412
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
n8n
|
Project |
n8n
|
Branch Review |
master
|
Run status |
|
Run duration | 04m 19s |
Commit |
|
Committer | कारतोफ्फेलस्क्रिप्ट™ |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
1
|
|
0
|
|
0
|
|
0
|
|
434
|
View all changes introduced in this branch ↗︎ |
Tests for review
17-sharing.cy.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Credential Usage in Cross Shared Workflows > should only show credentials in their personal project for members if the workflow was shared with them |
Test Replay
Screenshots
Video
|
The first 5 failed specs are shown, see all 23 specs in Cypress Cloud.
|
✅ All Cypress E2E specs passed |
0d7017d
to
3625b54
Compare
✅ All Cypress E2E specs passed |
Got released with |
Summary
We removed the full execution data from the payload for
executionFinished
push message in #11703, because that serialization sometimes required quite a lot of memory.This PR "temporarily" brings that data back, but now we instead serialize the data using
flatted.stringify
instead ofJSON.stringify
, which is a lot less expensive.This change is still temporary, as we should instead improve the state management in the frontend to construct the final execution data based on all the partial data already delivered in the
nodeExecuteAfter
push messages.Related Linear tickets, Github issues, and Community forum posts
PAY-2270
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)