Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Make new canvas connections go underneath node when looping backwards #11833

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alexgrozav
Copy link
Member

@alexgrozav alexgrozav commented Nov 21, 2024

Summary

  • Loop connection underneath node when going backwards
  • Add arrow marker at first loop segment

Old canvas:
image

New canvas:
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7725/connections-loop-above-node-not-below-also-missing-arrow

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Nov 21, 2024
@alexgrozav alexgrozav changed the title feat(editor): Mmake new canvas connections go underneath node when looping backwards feat(editor): Make new canvas connections go underneath node when looping backwards Nov 21, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant