Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Extract SupplyDataContext out of NodeExecutionFunctions (no-changelog) #11834

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor(core): Extract SupplyDataContext out of NodeExecutionFunctions (no-changelog) #11834

wants to merge 3 commits into from
+634 −301

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 21, 2024

Summary

This PR extracts SupplyDataContext object out of NodeExecutionFunctions, and adds unit tests for most of this code.

Related Linear tickets, Github issues, and Community forum posts

CAT-311

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 21, 2024
@netroy netroy force-pushed the CAT-311-extract-supply-data-context branch from b2f43de to 83cd20a Compare November 21, 2024 15:38
@netroy netroy force-pushed the CAT-311-extract-supply-data-context branch from 83cd20a to 06dfa1c Compare November 21, 2024 15:38
@netroy netroy force-pushed the CAT-311-extract-supply-data-context branch from f40a81e to 46aca60 Compare November 21, 2024 15:49
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 45.65217% with 50 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../src/node-execution-context/supply-data-context.ts 44.18% 48 Missing ⚠️
packages/core/src/NodeExecuteFunctions.ts 33.33% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@netroy netroy force-pushed the CAT-311-extract-supply-data-context branch from f16f444 to 4bed795 Compare November 21, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@netroy