feat(editor): Make the left sidebar in Expressions editor draggable #11838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
n8n-assistant
bot
added
n8n team
Joffcom
changed the title
dana-gill
force-pushed
the
node-1924-expression-modal-allow-changing-width-of-sections
branch
from
7a9fb33 to
5b076a5
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
dana-gill
force-pushed
the
node-1924-expression-modal-allow-changing-width-of-sections
branch
3 times, most recently
from
13e424c to
0ab7782
Compare
dana-gill
force-pushed
the
node-1924-expression-modal-allow-changing-width-of-sections
branch
2 times, most recently
from
e8c7903 to
673fe92
Compare
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-1924-expression-modal-allow-changing-width-of-sections
|
| Run status |
|
| Run duration | 04m 40s |
| Commit |
|
| Committer | Dana Lee |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
478
|
| View all changes introduced in this branch ↗︎ | |
|
|
This will prevent long import statements in later commits.
This encourages more type safety.
This makes it more uniformed with the Expressions editor. In addition, throttle is the more accurate since we want resize to be called during a certain period rather than delaying the call to resize. This also allows us to save calls to resizing.
This will make the draggable cursor more visible when it is in the middle of two Expression Editor panels.
ShireenMissi
force-pushed
the
node-1924-expression-modal-allow-changing-width-of-sections
branch
from
673fe92 to
3d8a14b
Compare
ShireenMissi
approved these changes
Nov 26, 2024
|
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1924-expression-modal-allow-changing-width-of-sections
branch
Merged
|
Got released with |
despairblue
pushed a commit
that referenced
this pull request
Nov 28, 2024
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a feature request in the Expressions editor to allow for the left sidebar to be resized for better readability
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)