fix(editor): Fix issues with push connect reconnection #13085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
alexgrozav
previously approved these changes
Feb 6, 2025
| import { useEventSourceClient } from '../useEventSourceClient'; | ||
|
|
||
| /** Mocked EventSource class to help testing */ | ||
| class MockEventSource extends EventTarget { |
There was a problem hiding this comment.
Would it make sense to extract this and MockWebSocket to src/__tests__/mocks.ts?
There was a problem hiding this comment.
Good point. Moved the mocks to their own files
Comment on lines
30
to
43
| const heartbeatTimer = ref<ReturnType<typeof setInterval> | null>(null); | ||
|
|
||
| const startHeartbeat = () => { | ||
| heartbeatTimer.value = setInterval(() => { | ||
| socket.value?.send(JSON.stringify({ type: 'heartbeat' })); | ||
| }, 30_000); | ||
| }; | ||
|
|
||
| const stopHeartbeat = () => { | ||
| if (heartbeatTimer.value) { | ||
| clearInterval(heartbeatTimer.value); | ||
| heartbeatTimer.value = null; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Can we extract this functionality into a useHeartbeat composable? Could be reused for other polling-type checks later.
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-622-issues-with-websocket-reconnection
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
433
|
| View all changes introduced in this branch ↗︎ | |
|
@alexgrozav addressed the feedback. Please have another look 🙏 |
alexgrozav
previously approved these changes
Feb 6, 2025
|
|
alexgrozav
approved these changes
Feb 6, 2025
|
✅ All Cypress E2E specs passed |
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-622/issues-with-websocket-reconnection
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)