fix(core): Do not save credential overwrites data into the database #13170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
tomi
previously approved these changes
Feb 10, 2025
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CAT-634-do-not-save-credential-overwrites-data-in-db
|
| Run status |
|
| Run duration | 04m 35s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
435
|
| View all changes introduced in this branch ↗︎ | |
|
|
|
✅ All Cypress E2E specs passed |
netroy
deleted the
CAT-634-do-not-save-credential-overwrites-data-in-db
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During oauth flows we update the credentials in the DB a few times. At some point we switched to rewriting the credentials data in the DB, with the data including defaults and overwrites.
This PR updated this code to do partial updates and deleted on credentials data to ensure that we only change the relevant parts of the data, and never include that did not come from the user or the 3rd party service.
Related Linear tickets, Github issues, and Community forum posts
CAT-634
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)