Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add template id to metadata when saving workflows from json #13172

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

mutdmour
Copy link
Contributor

@mutdmour mutdmour commented Feb 10, 2025

Summary

Add template id to metadata when saving workflows from json.
So that it's saved when metadata and telemetry is tracked correctly for it.

Screenshot 2025-02-10 at 16 41 30

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@mutdmour mutdmour changed the title fix(editor-ui): Add template id to metadata when saving workflows from json fix(editor): Add template id to metadata when saving workflows from json Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/editor-ui/src/composables/useCanvasOperations.ts 94.11% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 10, 2025
@mutdmour mutdmour marked this pull request as ready for review February 10, 2025 17:05
Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 🙌

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 11, 2025

n8n    Run #9224

Run Properties:  status check passed Passed #9224  •  git commit f2bfad3dfc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Project n8n
Branch Review ado-3197
Run status status check passed Passed #9224
Run duration 04m 31s
Commit git commit f2bfad3dfc: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 mutdmour 🗃️ e2e/*
Committer Mutasem Aldmour
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435
View all changes introduced in this branch ↗︎

@mutdmour mutdmour merged commit 2a92032 into master Feb 13, 2025
39 checks passed
@mutdmour mutdmour deleted the ado-3197 branch February 13, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants