Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix NDV panels size on narrow screens #13708

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

See this comment.

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-3263

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 32.50000% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nd/editor-ui/src/components/NDVDraggablePanels.vue 22.22% 21 Missing ⚠️
...s/frontend/editor-ui/src/stores/assistant.store.ts 50.00% 4 Missing ⚠️
packages/frontend/editor-ui/src/App.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Mar 5, 2025
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally on Mac. Cannot reproduce exact issue but tested different cases and seems to work fine (changed width of ndv, with assistant, trigger ndv..)

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Mar 10, 2025

n8n    Run #9668

Run Properties:  status check passed Passed #9668  •  git commit 4f5eab4cfa: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ADO-3263-fix-dnv-panels-on-narrow-screens
Run status status check passed Passed #9668
Run duration 04m 38s
Commit git commit 4f5eab4cfa: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 440
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants