Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n Form Node): Resolve expressions in HTML fields #13755

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michael-radency
Copy link
Contributor

Summary

Resolve expressions in HTML fields

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-8393/form-node-html-field-does-not-resolves-expressions
https://community.n8n.io/t/form-node-to-show-html-from-earlier-node/85404

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Mar 7, 2025
@dana-gill dana-gill self-requested a review March 7, 2025 11:52
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Form/utils.ts 92.30% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@dana-gill dana-gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need changes for the Form Trigger node 😅 Let me know if you need some help for this

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Mar 10, 2025

n8n    Run #9681

Run Properties:  status check passed Passed #9681  •  git commit 84c4024a25: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review n8n-8393-form-node-html-field-does-not-resolves-expressions
Run status status check passed Passed #9681
Run duration 04m 37s
Commit git commit 84c4024a25: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 440
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants