Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-commit hooks #58

Merged
merged 3 commits into from
Jun 8, 2024
Merged

update pre-commit hooks #58

merged 3 commits into from
Jun 8, 2024

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jun 8, 2024

  • switch from black to ruff for code formatting
  • remove useless pylint-specific comments
  • run updated pre-commit hooks on all files

Also adds a codecov config to allow CI checks to be more lenient.

- switch from black to ruff for code formatting
- remove useless pylint-specific comments
- run updated pre-commit hooks on all files
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (1f23cfc) to head (be514bc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
circuitpython_nrf24l01/rf24_mesh.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   86.73%   86.68%   -0.05%     
==========================================
  Files          16       16              
  Lines        2472     2463       -9     
==========================================
- Hits         2144     2135       -9     
  Misses        328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This should allow PRs' CI to pass when coverage has not changed significantly.

It is a achievement in itself to have any coverage at all for a hardware-specific library.
@2bndy5 2bndy5 merged commit a861db9 into master Jun 8, 2024
8 checks passed
@2bndy5 2bndy5 deleted the convention-updates branch June 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant