* add environment alias for migrating legacy clusters #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new parameter for feature - clusteralias * add config parameter * add handling of environments in reconciler for gcp * add environment alias to reconciler test Co-authored-by: Roger Bjørnstad <[email protected]> Co-authored-by: Vegar Sechmann Molvig <[email protected]>
thokra-nav
reviewed
Nov 26, 2024
| @@ -10,6 +10,7 @@ logLevel: info | |||
| logFormat: json | |||
| googleManagementProjectID: # mapped in fasit | |||
| tenantDomain: # mapped in fasit | |||
| clusterAlias: [] | |||
There was a problem hiding this comment.
Skal denne brukes noe sted? Mangler endringer i template fil isåfall
There was a problem hiding this comment.
Den skal settes i fasit når vi gjør endringer i fbm migreringen. Men kunne hatt med en kommentar der.
There was a problem hiding this comment.
Skjønner hva du mente nå ja, det hadde jeg glemt.
Co-authored-by: Thomas Krampl <[email protected]>
Co-authored-by: Vegar Sechmann Molvig <[email protected]>
…com/nais/api-reconcilers into add_environment_alias_for_migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Roger Bjørnstad [email protected]
Co-authored-by: Vegar Sechmann Molvig [email protected]