Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): include getting started instructions #20

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

tk-o
Copy link
Contributor

@tk-o tk-o commented Jan 9, 2025

Allow new users to run indexer locally for a selected active plugin.

Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk-o Hey so happy to see this! Reviewed and shared feedback 👍 Let's make this getting started amazing 💪

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk-o Thanks for your updates 👍 Reviewed and shared feedback 😄

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: lightwalker.eth <[email protected]>
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk-o Hey, this PR is a couple of weeks old now. Let's please get this PR ready to be successfully merged. To help speed up the completion of this PR I transferred most of the open goals into a separate issue #42 and assigned next steps on that issue to @BanaSeba. However, @tk-o, we still need your help to fix up and resolve the remaining open issues that are flagged on this PR. Let's please get this ready for merge as soon as we can. Thanks.

README.md Outdated
Clone this repository:
```
git clone [email protected]:namehash/ens-multichain-indexer.git
cd ens-multichain-indexer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these to ensnode now that we've renamed.

README.md Outdated
```
then review the docs inside your .env.local file for configuration instructions.

- `ACTIVE_PLUGIN` — set the plugin name you’d like to activate (`eth`, `base.eth`, or `linea.eth`). The activated plugin determines which contracts and chains are indexed. Currently only a single plugin can be activated at a time. Soon we will remove this constraint to allow multiple plugins to be activated concurrently.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all plugin related docs now that we are using ACTIVE_PLUGINS and support 1 or more active plugins.

README.md Outdated

## Overview

### `eth` plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please carefully review the whole structure of this file to ensure no merge conflicts and that it all will read naturally once we merge it into main.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@tk-o tk-o force-pushed the docs/getting-started branch from 41becf4 to 82ca8e9 Compare January 21, 2025 15:44
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tk-o Thanks for your updates 👍 Will merge this 🚀

@lightwalker-eth lightwalker-eth merged commit f003a49 into main Jan 21, 2025
1 check passed
@lightwalker-eth lightwalker-eth deleted the docs/getting-started branch January 21, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants