Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SC-24987] create LoadingReportIcon #282

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feat: [SC-24987] create LoadingReportIcon #282

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e7c7b16
feat: [SC-24987] create LoadingReportIcon
FrancoAguzzi Jul 18, 2024
83a63d5
feat: [SC-24987] create LoadingReportIcon
FrancoAguzzi Jun 1, 2024
cf7e287
refactor: add getNameGuardURLForEnsName function to NameGuard SDK
FrancoAguzzi Jun 5, 2024
6c1d66e
refactor: add getNameGuardURLForEnsName function to NameGuard SDK
FrancoAguzzi Jun 5, 2024
8567c33
refactor: add onIcon, onTooltip and onBadge click override props for …
FrancoAguzzi Jun 5, 2024
bb13f87
chore: fix loading data lacking issue
FrancoAguzzi Jun 5, 2024
ded3181
chore: move getNameGuardURLForENSname from NameGuard SDK to NameGuard…
FrancoAguzzi Jun 6, 2024
1984de5
feat: create url file in NameGuard React for utilities
FrancoAguzzi Jun 6, 2024
6dc768a
refactor: move NameGuard URL related logic to NameGuard React url.ts
FrancoAguzzi Jun 8, 2024
d229db6
chore: commented url file tests
FrancoAguzzi Jun 22, 2024
9667053
feat: changed module resolution of ens-utils
FrancoAguzzi Jun 25, 2024
13b08b1
fix: align build config in examples.nameguard.io
FrancoAguzzi Jul 9, 2024
1e785c0
fix: update type file reference of nameguard-react
FrancoAguzzi Jul 9, 2024
0b8f598
debug: update ci_sdk.yml to log node_modules content
FrancoAguzzi Jul 9, 2024
06f1706
debug: update back ci_sdk.yml after bug test
FrancoAguzzi Jul 9, 2024
b643ecf
debug: finish undoing changes to ci_sdk.yml
FrancoAguzzi Jul 9, 2024
9afae03
fix: add vitest to nameguard-react
FrancoAguzzi Jul 19, 2024
63d4e55
fix: update pnpm-lock file
FrancoAguzzi Jul 19, 2024
ef0f788
fix: update examples.nameguard.io ens-utils version
FrancoAguzzi Jul 19, 2024
a038605
Merge branch 'main' into feat/create-loading-report-icon
FrancoAguzzi Jul 19, 2024
0cc2a45
Merge remote-tracking branch 'origin/main' into feat/create-loading-r…
FrancoAguzzi Aug 19, 2024
f6a54b8
chore: update packages dependencies
FrancoAguzzi Aug 27, 2024
4f82840
Merge remote-tracking branch 'origin/main' into feat/create-loading-r…
FrancoAguzzi Aug 27, 2024
f9621b3
Merge branch 'main' into feat/create-loading-report-icon
notrab Aug 28, 2024
5e1d864
Merge remote-tracking branch 'origin/main' into feat/create-loading-r…
FrancoAguzzi Aug 29, 2024
3b7a92e
feat: import Tooltip from namekit-react in nameguard-react comps
FrancoAguzzi Aug 29, 2024
cb60d00
Merge remote-tracking branch 'origin/main' into feat/create-loading-r…
FrancoAguzzi Sep 6, 2024
15c15e8
feat: update Tooltip imports to be in alignment with new Tooltip expo…
FrancoAguzzi Sep 10, 2024
ea54703
Fix PR 282 (#395)
lightwalker-eth Sep 12, 2024
766e4c6
Undo any changes to price.ts in this branch
lightwalker-eth Sep 12, 2024
1ceabfe
Remove changes to ens-utils from this branch
lightwalker-eth Sep 12, 2024
bc4192d
Remove changes to nameguard-sdk from this branch
lightwalker-eth Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-spoons-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@namehash/nameguard-react": minor
---

Add onIcon, onTooltip and onBadge click handlers for Report components
6 changes: 6 additions & 0 deletions .changeset/fair-pumas-chew.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@namehash/nameguard-react": minor
"@namehash/nameguard": minor
---

Use new function getNameGuardURLForENSname from @namehash/nameguard where possible
6 changes: 6 additions & 0 deletions .changeset/famous-jobs-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@namehash/nameguard-react": minor
"@namehash/ens-utils": minor
---

Move NameGuard URL related logic to NameGuard React url.ts
1 change: 1 addition & 0 deletions apps/examples.nameguard.io/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare module "@namehash/nameguard-react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi Please help me understand why we added this file and this line of code.

Is this actually needed? If so, why? If it is needed, then are we doing something special to cause it to be needed in the examples.nameguard.io app? If we aren't doing anything special but still need this then shouldn't we be adding some documentation in the readme files for the related packages instructing everyone to do this when making use of the package?

1 change: 1 addition & 0 deletions apps/examples.nameguard.io/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"@headlessui/react": "1.7.17",
"@namehash/nameguard": "workspace:*",
"@namehash/nameguard-react": "workspace:*",
"@namehash/ens-utils": "workspace:*",
"@namehash/nameguard-js": "workspace:*",
"viem": "^2.9.3",
"classcat": "5.0.4",
Expand Down
12 changes: 7 additions & 5 deletions apps/examples.nameguard.io/src/app/components/ImpersonationReport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
"use client";

import { Rating, type SecurePrimaryNameResult } from "@namehash/nameguard";
import { type SecurePrimaryNameResult } from "@namehash/nameguard";
import {
RatingIcon,
RatingIconSize,
RatingLoadingIcon,
viewNameReportURL,
ratingTextColor,
RatingLoadingIcon,
} from "@namehash/nameguard-react";
import cc from "classcat";

import { Tooltip } from "./Tooltip";
import { buildENSName } from "@namehash/ens-utils";

type ImpersonationReportProps = {
data?: SecurePrimaryNameResult;
Expand Down Expand Up @@ -66,9 +68,9 @@ export function ImpersonationReport({ data }: ImpersonationReportProps) {
</div>
<div className="text-sm text-white">
<a
href={`https://nameguard.io/inspect/${encodeURIComponent(
nameguard_result.name,
)}`}
href={
viewNameReportURL(buildENSName(nameguard_result.name)).href
}
className="underline"
rel="noopener noreferrer"
target="_blank"
Expand Down
1 change: 1 addition & 0 deletions apps/examples.nameguard.io/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare module "@namehash/nameguard-react";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi Please help me understand why we added this file and this line of code.

Is this actually needed? If so, why? If it is needed, then are we doing something special to cause it to be needed in the examples.nameguard.io app? If we aren't doing anything special but still need this then shouldn't we be adding some documentation in the readme files for the related packages instructing everyone to do this when making use of the package?

2 changes: 1 addition & 1 deletion apps/examples.nameguard.io/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "bundler",
"moduleResolution": "node",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please coordinate any changes to tsconfig.json files with Jamie. Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrancoAguzzi Whenever you make any changes to any build configuration files, please proactively add a comment about that change inside the PR in GitHub that explains:

  1. Why that change was needed.
  2. The current status of getting approval from @notrab of the change.

"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",
Expand Down
Loading
Loading