Refine Entire Platform To Support Uninspected Names in NameGuard #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bedf683 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
notrab
requested review from
djstrong,
Carbon225,
lightwalker-eth,
FrancoAguzzi,
BanaSeba and
eduramme
as code owners
lightwalker-eth
requested changes
Aug 19, 2024
There was a problem hiding this comment.
@notrab Hey, overall looks good. Thank you 👍
- I added some change suggestions in the following PR. Could you please have a look and merge this into your PR if that looks good to you? https://github.com/namehash/namekit/pull/356/files
- Could you please add a changeset to this PR? We need to do this for any PR that impacts a package that is published to NPM.
* labels passed into LabelList are never undefined * Refine example uninspected name
lightwalker-eth
force-pushed
the
notrab/sc-25568/refine-entire-platform-to-support-uninspected
branch
from
987976c to
bedf683
Compare
lightwalker-eth
deleted the
notrab/sc-25568/refine-entire-platform-to-support-uninspected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.