Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get log probability color #512

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Get log probability color #512

wants to merge 3 commits into from

Conversation

djstrong
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: 6442059

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
namekit.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 2:51pm
namerank.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 2:51pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples.nameguard.io ⬜️ Skipped (Inspect) Dec 30, 2024 2:51pm
namegraph.dev ⬜️ Skipped (Inspect) Dec 30, 2024 2:51pm
nameguard.io ⬜️ Skipped (Inspect) Dec 30, 2024 2:51pm
namehashlabs.org ⬜️ Skipped (Inspect) Dec 30, 2024 2:51pm
storybook.namekit.io ⬜️ Skipped (Inspect) Dec 30, 2024 2:51pm

@vercel vercel bot temporarily deployed to Preview – namehashlabs.org December 30, 2024 14:50 Inactive
@vercel vercel bot temporarily deployed to Preview – examples.nameguard.io December 30, 2024 14:50 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook.namekit.io December 30, 2024 14:50 Inactive
@vercel vercel bot temporarily deployed to Preview – namegraph.dev December 30, 2024 14:50 Inactive
@vercel vercel bot temporarily deployed to Preview – nameguard.io December 30, 2024 14:50 Inactive
Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djstrong Hey great to see this!

@notrab Hey, could you please take the lead on the next steps for this PR? Thank you!

@@ -16,9 +16,26 @@ export const Indicator = ({ value }: IndicatorProps) => {
}
};

const getLogProbabilityColor = (val: number): [number, number, number] => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab Hey, could you please help to advance next steps here? The big picture is that this function is attempting to generate a RGB hex code that can be used to dynamically determine the color of an indicator based on a log_probability value. I asked @djstrong to focus on the math side of this logic so that we could then pass this goal off to you for refinement to align with TypeScript / Tailwind / CSS best practices. Please let us know if any questions!

@notrab Requested enhancements on this for you to lead include:

  1. Rename the val param to something approximating log_probability to be more self documenting
  2. Refine the return type to better align with best practices for how a color code might be returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants