fix: Show error when signing in with unregistered email (#299)

namesakefyi · Dec 22, 2024 · e4a7813 · e4a7813
1 parent 9c9a59b
commit e4a7813
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/.changeset/polite-monkeys-travel.md b/.changeset/polite-monkeys-travel.md
@@ -0,0 +1,5 @@
+---
+"namesake": minor
+---
+
+fix: Show error when signing in with unregistered email
diff --git a/src/routes/_unauthenticated/signin.tsx b/src/routes/_unauthenticated/signin.tsx
@@ -44,25 +44,26 @@ const SignIn = () => {
     setIsSubmitting(true);
     setError(null);
 
-    await signIn("password", {
-      flow,
-      email,
-      password,
-      redirectTo: "/quests",
-    })
-      .catch((error) =>
-        error instanceof ConvexError
-          ? setError(error.message)
-          : setError(error),
-      )
-      .then(() => navigate({ to: "/" }))
-      .finally(() => setIsSubmitting(false));
+    try {
+      await signIn("password", {
+        flow,
+        email,
+        password,
+        redirectTo: "/quests",
+      });
+      navigate({ to: "/" });
+    } catch (error) {
+      setError("Couldn't sign in. Check your information and try again.");
+    } finally {
+      setIsSubmitting(false);
+    }
   };
 
-  if (flow === "reset")
+  if (flow === "reset") {
     return (
       <ForgotPassword onBack={() => setFlow("signIn")} defaultEmail={email} />
     );
+  }
 
   return (
     <Tabs selectedKey={flow} onSelectionChange={setFlow}>