Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support adding questFields to a questStep; display form fields within a quest #113

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

evadecker
Copy link
Member

@evadecker evadecker commented Sep 29, 2024

What changed?

  • Connect questSteps table to questFields table by supplying an array of questFields to a fields column for a step
  • Create a new QuestStep component to handle displaying the step title, description, and fields
  • Use the QuestStep component within the admin and on user-facing quests
  • Support linking questFields to a questStep via the Admin UI
  • Extend Checkbox component with support for label and description

Why?

Ongoing work to provide v1 experience. Pre-defining fields that can be re-used across multiple quests will help enforce consistency and allow us to define canonical inputs for common entries like email and name.

How was this change made?

Removed old tables, connected new data, tested end-to-end to make sure everything works.

How was this tested?

Manual testing.

Anything else?

First part of #111; will follow-up with saving user data from form fields.

Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: cf33776

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
namesake Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 29, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 8.6%
⬇️ -0.37%
328 / 3810
🔵 Statements 8.6%
⬇️ -0.37%
328 / 3810
🔵 Functions 1.16%
⬇️ -0.01%
1 / 86
🔵 Branches 7.14%
⬇️ -0.08%
6 / 84
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
convex/questFields.ts 0% 0% 0% 0% 1-4, 6-11, 13-24, 26-41
convex/questSteps.ts 0% 0% 0% 0% 1-3, 5-6, 8-22, 24, 26, 28-32, 34-39, 41-44, 46-48
convex/schema.ts 100% 100% 100% 100%
src/components/Checkbox/Checkbox.tsx 0% 0% 0% 0% 1, 10-13, 23-29, 32-35, 37, 40, 42-50, 52-67, 69-70, 77-85, 88-94, 96-100, 102-103, 107-109, 114
src/components/QuestStep/QuestStep.tsx 0% 0% 0% 0% 1, 3-11, 19-27, 30-35, 38-43, 46-52, 54, 57-64, 66-68, 70, 72-75, 77-82, 85, 88
src/routes/_authenticated/admin/quests/$questId.tsx 0% 0% 0% 0% 1, 13-15, 17-21, 23-25, 27-40, 42-44, 46-50, 52-62, 64-69, 71-81, 88, 91-92, 96-103, 105-107, 109-119, 122, 124-130, 132-133, 136, 138-140, 142, 147-157, 159-160, 163, 167-168, 171, 181
src/routes/_authenticated/quests/$questId.tsx 0% 0% 0% 0% 1, 8-10, 12-15, 17-19, 21-34, 36-39, 41-42, 44-53, 55, 60-62, 64-66, 70-71, 78-87, 94, 98
Generated in workflow #82

Copy link

cloudflare-workers-and-pages bot commented Sep 29, 2024

Deploying namesake with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf33776
Status: ✅  Deploy successful!
Preview URL: https://e2afd860.namesake-639.pages.dev
Branch Preview URL: https://add-fields.namesake-639.pages.dev

View logs

@evadecker evadecker merged commit 64475c3 into main Sep 29, 2024
7 checks passed
@evadecker evadecker deleted the add-fields branch September 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant