Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary fields from survey creator #269

Merged
merged 4 commits into from
Dec 8, 2024

Conversation

evadecker
Copy link
Member

@evadecker evadecker commented Dec 8, 2024

What changed?

Add custom config to survey creator implementation to hide features and question types which are unnecessary. Resolves #267

Why?

Keep the UI focused and lean.

How was this change made?

Created a new surveyCreatorConfig file and instantiated it during setup.

How was this tested?

Manual testing to verify items display and hide.

Anything else?

Filed an issue on the SurveyJS repo about a question type I couldn't locate: surveyjs/survey-creator#6202

Copy link

changeset-bot bot commented Dec 8, 2024

⚠️ No Changeset found

Latest commit: c88a2da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@evadecker evadecker added this to the Namesake v1.0 milestone Dec 8, 2024
@evadecker evadecker added the frontend CSS, HTML, and JS changes label Dec 8, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.4%
⬇️ -0.14%
1711 / 5627
🔵 Statements 30.4%
⬇️ -0.14%
1711 / 5627
🔵 Functions 31.14%
⬆️ +0.38%
57 / 183
🔵 Branches 59.74%
⬆️ +0.25%
95 / 159
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/routes/_authenticated/admin_/quests.$questId.form.tsx 0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
0%
🟰 ±0%
1-106
src/utils/surveyCreatorConfig.ts 0% 100% 100% 0% 4-34
Generated in workflow #193 for commit 701e554 by the Vitest Coverage Report Action

Copy link

cloudflare-workers-and-pages bot commented Dec 8, 2024

Deploying namesake with  Cloudflare Pages  Cloudflare Pages

Latest commit: 701e554
Status: ✅  Deploy successful!
Preview URL: https://df5fa94e.namesake-639.pages.dev
Branch Preview URL: https://unnecessary-fields.namesake-639.pages.dev

View logs

@evadecker evadecker merged commit e63b574 into main Dec 8, 2024
10 checks passed
@evadecker evadecker deleted the unnecessary-fields branch December 8, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend CSS, HTML, and JS changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable unnecessary field types and settings in SurveyJS creator
1 participant