Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PasswordStrength component #301

Merged
merged 2 commits into from
Dec 21, 2024
Merged

feat: PasswordStrength component #301

merged 2 commits into from
Dec 21, 2024

Conversation

evadecker
Copy link
Member

What changed?

Create a new PasswordStrength component. Resolves #300.

CleanShot.2024-12-20.at.22.49.06.mp4

CleanShot 2024-12-20 at 23 01 40@2x

Why?

Needed for #287.

How was this change made?

Relocated existing/unused Meter component from /components/common to /components/app. Added styling. Added Storybook stories.

How was this tested?

Added unit tests for the component to validate labels and colors are displayed, banners are displayed for warnings and suggestions, and invalid values are not accepted.

Anything else?

Reinstalls @storybook/addon-controls. Modifies Banner padding slightly.

Copy link

changeset-bot bot commented Dec 21, 2024

⚠️ No Changeset found

Latest commit: ca02e4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend CSS, HTML, and JS changes backend Schema, query, and mutation changes testing Unit and e2e tests labels Dec 21, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 21, 2024

Deploying namesake with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca02e4d
Status: ✅  Deploy successful!
Preview URL: https://2e4b1826.namesake-639.pages.dev
Branch Preview URL: https://password-strength.namesake-639.pages.dev

View logs

@github-actions github-actions bot removed the backend Schema, query, and mutation changes label Dec 21, 2024
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 45.05%
⬆️ +1.01%
2577 / 5720
🔵 Statements 45.05%
⬆️ +1.01%
2577 / 5720
🔵 Functions 50.21%
⬆️ +0.64%
117 / 233
🔵 Branches 76.84%
⬆️ +0.65%
229 / 298
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/app/PasswordStrength/PasswordStrength.tsx 100% 100% 100% 100%
src/components/common/Banner/Banner.tsx 98.03%
⬆️ +1.96%
83.33%
⬆️ +16.67%
100%
🟰 ±0%
98.03%
⬆️ +1.96%
53
Generated in workflow #217 for commit ca02e4d by the Vitest Coverage Report Action

@evadecker evadecker merged commit 8414564 into main Dec 21, 2024
11 checks passed
@evadecker evadecker deleted the password-strength branch December 21, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend CSS, HTML, and JS changes testing Unit and e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PasswordStrength component
1 participant