feat: Display navigation controls within forms #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 22bc420 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
evadecker
changed the title
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Deploying namesake with
|
| Latest commit: |
22bc420
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://241971aa.namesake-639.pages.dev |
| Branch Preview URL: | https://form-navigation.namesake-639.pages.dev |
|
Looks great. Ideas for design improvements that we might not care about now but might be ncie later:
|
mbbischoff
reviewed
Feb 17, 2025
mbbischoff
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Create a new
FormNavigationcomponent which displays a next button, previous button, and popover menu with all questions in a form. Resolves #324CleanShot.2025-02-16.at.20.37.11.mp4
Why?
Make it easy for users to navigate through a form and jump to specific questions.
How was this change made?
Created a new
IntersectionObserverto monitor the currently-in-view question and update internal React state and the URL hash. Use that state to populate the menu and the URLs for the next and previous buttons.How was this tested?
Anything else?
Added some basic tests for
FormContainer.Fix before merge: