Various SMB1 fixes #491
Closed
Various SMB1 fixes #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 29, 2024 11:09
process rpc requests similarly to smb2 code. in particular, do not assume the default response buffer is large enough to hold the rpc response. Signed-off-by: Marios Makassikis <[email protected]>
Signed-off-by: Marios Makassikis <[email protected]>
while here, log whatever message type was received Signed-off-by: Marios Makassikis <[email protected]>
fixes fd leaks which result in ksmbd not being able to accept new clients. Can be reproduced with repeatedly renaming a file on the share. Signed-off-by: Marios Makassikis <[email protected]>
needed after commit 6f6416f ("ksmbd: fix user-after-free from session log off"), as the ksmbd_user_session_put() call in server.c will be called regardless of the protocol version. Signed-off-by: Marios Makassikis <[email protected]>
mmakassikis
force-pushed
the
private/marios/smb1_next
branch
2 times, most recently
from
4e65b20
to
e6adc5a
Compare
|
Applied them to #next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking the latest ksmbd patches, I noticed I have some local SMB1 specific changes that I forgot to upstream:
The first two fix memory corruptions. The third is more of logic error in that the server does not send an error back to the client. The last result in resource leaks.