Exfat next misc #18
Open
Exfat next misc #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s_lock which is for protecting concurrent access of file operations is too huge for cluster bitmap protection, so introduce a new bitmap_lock to narrow the lock range if only need to access cluster bitmap. Signed-off-by: Hyeongseok Kim <[email protected]> Acked-by: Sungjong Seo <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
Add FITRIM ioctl to enable discarding unused blocks while mounted. As current exFAT doesn't have generic ioctl handler, add empty ioctl function first, and add FITRIM handler. Signed-off-by: Hyeongseok Kim <[email protected]> Reviewed-by: Chaitanya Kulkarni <[email protected]> Acked-by: Sungjong Seo <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Namjae Jeon <[email protected]>
Change-Id: I4c630201d043b7a763d9faea2a87ca42aafdb8ec Signed-off-by: Matthieu Castet <[email protected]>
Change-Id: I8db1e9660dcb29f206a4dca396d945504965126f Signed-off-by: Matthieu Castet <[email protected]>
namjaejeon
reviewed
Mar 17, 2021
| #define FAT_ENT_OFFSET_BYTE_IN_SECTOR(sb, loc) \ | ||
| ((loc << FAT_ENT_SIZE_BITS) & (sb->s_blocksize - 1)) | ||
| (((loc) << FAT_ENT_SIZE_BITS) & (sb->s_blocksize - 1)) |
There was a problem hiding this comment.
there is no description in patch why you add () in macro.
There was a problem hiding this comment.
I am doing some patches, to do some optimization.
If I use FAT_ENT_OFFSET_BYTE_IN_SECTOR with an expression, it fails.
I will update the patch.
namjaejeon
reviewed
Mar 17, 2021
| return false; | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add patch description why this patch is needed. and if you think this patch is needed from exfat in kernel mainline, Can you send the patch to LKML ?
|
Thanks for your patch. Could you please add prefix in patch ? i.e. "exfat:" and patch description also... |
namjaejeon
force-pushed
the
exfat-next
branch
2 times, most recently
from
533d819 to
436aec7
Compare
namjaejeon
force-pushed
the
exfat-next
branch
2 times, most recently
from
4b4dc43 to
f104dcf
Compare
|
Can I help in any way to get this merged? Having FSTRIM support will solve some performance issues for us with exfat on SMR drives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.