-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 11 NuGet dependencies #370
base: main
Are you sure you want to change the base?
Update 11 NuGet dependencies #370
Conversation
Bumps nanoFramework.Iot.Device.Button from 1.2.718 to 1.2.737</br>Bumps nanoFramework.Iot.Device.Ws28xx.Esp32 from 1.2.696 to 1.2.737</br>Bumps Nerdbank.GitVersioning from 3.7.112 to 3.7.115</br>Bumps nanoFramework.Iot.Device.Mpu6886 from 1.2.718 to 1.2.737</br>Bumps nanoFramework.Iot.Device.Buzzer from 1.2.718 to 1.2.737</br>Bumps nanoFramework.Iot.Device.ePaper from 1.0.558 to 1.0.573</br>Bumps nanoFramework.Iot.Device.Rtc from 1.2.718 to 1.2.737</br>Bumps nanoFramework.Iot.Device.Bmm150 from 1.2.704 to 1.2.737</br>Bumps nanoFramework.Iot.Device.Ip5306 from 1.2.718 to 1.2.737</br>Bumps nanoFramework.Iot.Device.Axp192 from 1.2.718 to 1.2.737</br>Bumps nanoFramework.Iot.Device.Chsc6540 from 1.1.696 to 1.1.737</br> [version update] ###⚠️ This is an automated update.⚠️
WalkthroughThis pull request involves updating dependency versions across multiple Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Tests/M5Core2TestApp/packages.lock.json (1)
25-27
: LGTM! Consistent version updates across dependencies.All IoT Device dependencies have been updated to version 1.2.737, maintaining consistency with other projects.
Summary of changes across all files:
- IoT Device packages updated from various versions (1.2.718, 1.2.704, 1.2.696) to 1.2.737
- Nerdbank.GitVersioning updated from 3.7.112 to 3.7.115
- All version ranges are strictly pinned using [x.y.z, x.y.z] format
Consider adding a centralized version management system (like Directory.Packages.props) to maintain consistent versions across all projects and simplify future updates.
Also applies to: 31-33, 37-39, 49-51, 55-57
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (41)
Tests/AtomLiteTestApp/AtomLiteTestApp.nfproj
is excluded by none and included by noneTests/AtomLiteTestApp/packages.config
is excluded by none and included by noneTests/AtomMatrixTestApp/AtomMatrixTestApp.nfproj
is excluded by none and included by noneTests/AtomMatrixTestApp/packages.config
is excluded by none and included by noneTests/FireTestApp/FireTestApp.nfproj
is excluded by none and included by noneTests/FireTestApp/packages.config
is excluded by none and included by noneTests/M5Core2TestApp/M5Core2TestApp.nfproj
is excluded by none and included by noneTests/M5Core2TestApp/packages.config
is excluded by none and included by noneTests/M5CoreTestApp/M5CoreTestApp.nfproj
is excluded by none and included by noneTests/M5CoreTestApp/packages.config
is excluded by none and included by noneTests/M5StickTestApp/M5StickTestApp.nfproj
is excluded by none and included by noneTests/M5StickTestApp/packages.config
is excluded by none and included by noneTests/ToughTestApp/ToughTestApp.nfproj
is excluded by none and included by noneTests/ToughTestApp/packages.config
is excluded by none and included by nonenanoFramework.AtomLite.nuspec
is excluded by none and included by nonenanoFramework.AtomLite/nanoFramework.AtomLite.nfproj
is excluded by none and included by nonenanoFramework.AtomLite/packages.config
is excluded by none and included by nonenanoFramework.AtomMatrix.nuspec
is excluded by none and included by nonenanoFramework.AtomMatrix/nanoFramework.AtomMatrix.nfproj
is excluded by none and included by nonenanoFramework.AtomMatrix/packages.config
is excluded by none and included by nonenanoFramework.CoreInk.nuspec
is excluded by none and included by nonenanoFramework.CoreInk/nanoFramework.CoreInk.nfproj
is excluded by none and included by nonenanoFramework.CoreInk/packages.config
is excluded by none and included by nonenanoFramework.Fire.nuspec
is excluded by none and included by nonenanoFramework.Fire/nanoFramework.Fire.nfproj
is excluded by none and included by nonenanoFramework.Fire/packages.config
is excluded by none and included by nonenanoFramework.M5Core.nuspec
is excluded by none and included by nonenanoFramework.M5Core/nanoFramework.M5Core.nfproj
is excluded by none and included by nonenanoFramework.M5Core/packages.config
is excluded by none and included by nonenanoFramework.M5Core2.nuspec
is excluded by none and included by nonenanoFramework.M5Core2/nanoFramework.M5Core2.nfproj
is excluded by none and included by nonenanoFramework.M5Core2/packages.config
is excluded by none and included by nonenanoFramework.M5StickC.nuspec
is excluded by none and included by nonenanoFramework.M5StickC/nanoFramework.M5StickC.nfproj
is excluded by none and included by nonenanoFramework.M5StickC/packages.config
is excluded by none and included by nonenanoFramework.M5StickCPlus.nuspec
is excluded by none and included by nonenanoFramework.M5StickCPlus/nanoFramework.M5StickCPlus.nfproj
is excluded by none and included by nonenanoFramework.M5StickCPlus/packages.config
is excluded by none and included by nonenanoFramework.Tough.nuspec
is excluded by none and included by nonenanoFramework.Tough/nanoFramework.Tough.nfproj
is excluded by none and included by nonenanoFramework.Tough/packages.config
is excluded by none and included by none
📒 Files selected for processing (16)
Tests/AtomLiteTestApp/packages.lock.json
(1 hunks)Tests/AtomMatrixTestApp/packages.lock.json
(1 hunks)Tests/FireTestApp/packages.lock.json
(1 hunks)Tests/M5Core2TestApp/packages.lock.json
(2 hunks)Tests/M5CoreTestApp/packages.lock.json
(1 hunks)Tests/M5StickTestApp/packages.lock.json
(2 hunks)Tests/ToughTestApp/packages.lock.json
(1 hunks)nanoFramework.AtomLite/packages.lock.json
(2 hunks)nanoFramework.AtomMatrix/packages.lock.json
(2 hunks)nanoFramework.CoreInk/packages.lock.json
(3 hunks)nanoFramework.Fire/packages.lock.json
(2 hunks)nanoFramework.M5Core/packages.lock.json
(2 hunks)nanoFramework.M5Core2/packages.lock.json
(3 hunks)nanoFramework.M5StickC/packages.lock.json
(3 hunks)nanoFramework.M5StickCPlus/packages.lock.json
(3 hunks)nanoFramework.Tough/packages.lock.json
(3 hunks)
🔇 Additional comments (16)
Tests/AtomLiteTestApp/packages.lock.json (1)
25-27
: LGTM! Version updates are consistent.The dependency updates are patch version increments, which typically indicate backward-compatible bug fixes:
nanoFramework.Iot.Device.Button
: 1.2.718 → 1.2.737nanoFramework.Iot.Device.Ws28xx.Esp32
: 1.2.696 → 1.2.737Let's verify version consistency across projects:
Also applies to: 31-33
✅ Verification successful
Version consistency verified across all projects
Both packages are consistently updated to version 1.2.737 in all package configurations, lock files, and NuGet specifications.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check version consistency of updated packages across all projects. # Test: Search for these package versions in all packages.lock.json files. # Expect: All occurrences should use the same version. echo "Checking nanoFramework.Iot.Device.Button versions:" rg '"nanoFramework\.Iot\.Device\.Button"' -A 2 echo "Checking nanoFramework.Iot.Device.Ws28xx.Esp32 versions:" rg '"nanoFramework\.Iot\.Device\.Ws28xx\.Esp32"' -A 2Length of output: 16738
Tests/AtomMatrixTestApp/packages.lock.json (1)
25-27
: Same version updates as in AtomLiteTestApp.The changes are identical to those in AtomLiteTestApp/packages.lock.json.
Also applies to: 31-33
nanoFramework.AtomLite/packages.lock.json (1)
79-81
: LGTM! Nerdbank.GitVersioning update looks good.The update from 3.7.112 to 3.7.115 is a patch version increment, which typically indicates backward-compatible bug fixes.
Let's verify version consistency for this package:
✅ Verification successful
Version consistency verified for Nerdbank.GitVersioning
All projects in the codebase are using version 3.7.115 consistently.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check version consistency of Nerdbank.GitVersioning across projects. # Test: Search for this package version in all packages.lock.json files. # Expect: All occurrences should use version 3.7.115. echo "Checking Nerdbank.GitVersioning versions:" rg '"Nerdbank\.GitVersioning"' -A 2Length of output: 5860
nanoFramework.AtomMatrix/packages.lock.json (1)
37-39
: LGTM! Mpu6886 update follows the same pattern.The update of
nanoFramework.Iot.Device.Mpu6886
from 1.2.718 to 1.2.737 is consistent with other IoT device library updates.Let's verify version consistency:
✅ Verification successful
Version consistency verified for nanoFramework.Iot.Device.Mpu6886
All projects in the codebase consistently use version 1.2.737 of the package.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check version consistency of Mpu6886 across projects. # Test: Search for this package version in all packages.lock.json files. # Expect: All occurrences should use version 1.2.737. echo "Checking nanoFramework.Iot.Device.Mpu6886 versions:" rg '"nanoFramework\.Iot\.Device\.Mpu6886"' -A 2Length of output: 8553
nanoFramework.CoreInk/packages.lock.json (1)
31-33
: LGTM! New IoT device library updates follow consistent patterns.New updates are all patch version increments:
nanoFramework.Iot.Device.Buzzer
: 1.2.718 → 1.2.737nanoFramework.Iot.Device.ePaper
: 1.0.558 → 1.0.573nanoFramework.Iot.Device.Rtc
: 1.2.718 → 1.2.737Let's verify version consistency:
Also applies to: 43-45, 49-51
✅ Verification successful
✓ Version consistency verified across all IoT device library dependencies
All updated packages show perfect version alignment across the entire codebase:
nanoFramework.Iot.Device.Buzzer
(1.2.737)nanoFramework.Iot.Device.ePaper
(1.0.573)nanoFramework.Iot.Device.Rtc
(1.2.737)🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check version consistency of new IoT device libraries. # Test: Search for these package versions in all packages.lock.json files. # Expect: All occurrences should use the specified versions. echo "Checking nanoFramework.Iot.Device.Buzzer versions:" rg '"nanoFramework\.Iot\.Device\.Buzzer"' -A 2 echo "Checking nanoFramework.Iot.Device.ePaper versions:" rg '"nanoFramework\.Iot\.Device\.ePaper"' -A 2 echo "Checking nanoFramework.Iot.Device.Rtc versions:" rg '"nanoFramework\.Iot\.Device\.Rtc"' -A 2Length of output: 11945
Tests/ToughTestApp/packages.lock.json (1)
25-27
: LGTM! Dependency updates look good.The version updates for both dependencies follow semantic versioning with patch version increments, maintaining backward compatibility.
Also applies to: 31-33
Tests/M5StickTestApp/packages.lock.json (1)
31-33
: LGTM! Consistent dependency updates.All IoT device dependencies have been updated to version 1.2.737, maintaining consistency across the package ecosystem.
Also applies to: 37-39, 49-51, 55-57
nanoFramework.M5StickC/packages.lock.json (1)
31-33
: LGTM! Version updates are consistent.All dependencies have been updated to their latest patch versions:
- IoT device packages to 1.2.737
- Nerdbank.GitVersioning to 3.7.115
Also applies to: 37-39, 49-51, 55-57, 127-129
nanoFramework.Tough/packages.lock.json (1)
31-33
: LGTM! Version updates are aligned.Dependencies have been consistently updated across the project:
- IoT device packages to 1.2.737
- Nerdbank.GitVersioning to 3.7.115
Also applies to: 37-39, 49-51, 145-147
Tests/M5CoreTestApp/packages.lock.json (1)
19-21
: LGTM! Dependency versions are in sync.All IoT device packages have been updated to version 1.2.737, maintaining consistency with other projects in the solution.
Also applies to: 25-27, 31-33, 37-39
nanoFramework.M5StickCPlus/packages.lock.json (1)
31-33
: Verify compatibility of updated dependencies.The following dependencies have been updated:
- IoT Device packages from 1.2.718 to 1.2.737
- Nerdbank.GitVersioning from 3.7.112 to 3.7.115
Run the following script to check for any breaking changes or known issues:
Also applies to: 37-39, 43-45, 55-57, 61-63, 139-141
✅ Verification successful
Dependencies update verified as compatible
The update from 1.2.718 to 1.2.737 consists of routine maintenance changes with no breaking changes or reported issues. All IoT Device packages are consistently updated to the same version.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for breaking changes in the updated dependencies # Search for any BREAKING CHANGE markers in commit messages echo "Checking for breaking changes in IoT Device packages..." gh api graphql -f query=' { search(query: "org:nanoframework BREAKING CHANGE", type: COMMIT, first: 10) { nodes { ... on Commit { messageHeadline message committedDate } } } }' # Check for any reported issues related to these versions echo "Checking for reported issues..." gh api graphql -f query=' { search(query: "org:nanoframework 1.2.737 is:issue", type: ISSUE, first: 10) { nodes { ... on Issue { title url state } } } }'Length of output: 1378
Script:
#!/bin/bash # Search for changelog files and relevant version information echo "Searching for changelog files..." fd -i changelog echo -e "\nSearching for version-related commits..." gh search commits --repo="nanoframework/nf-interpreter" "bump version 1.2.7" --limit 20 echo -e "\nChecking for compatibility documentation..." fd -e md | xargs rg -l "1\.2\.(718|737)"Length of output: 436
Script:
#!/bin/bash # Check changelog contents echo "Reading CHANGELOG.md..." cat CHANGELOG.md echo -e "\nSearching for version bumps with different pattern..." gh search commits --repo="nanoframework/nf-interpreter" "update version" --limit 10 echo -e "\nChecking documentation with broader version pattern..." rg -l "## \[?1\.2\." CHANGELOG.md README.md 2>/dev/null || trueLength of output: 65987
Tests/FireTestApp/packages.lock.json (1)
31-33
: LGTM! Consistent version updates across IoT Device dependencies.All IoT Device dependencies have been updated to version 1.2.737, maintaining consistency across the package versions.
Also applies to: 37-39, 43-45, 49-51, 55-57, 61-63
nanoFramework.M5Core/packages.lock.json (1)
25-27
: LGTM! Consistent version updates across dependencies.All IoT Device dependencies have been updated to version 1.2.737 and Nerdbank.GitVersioning to 3.7.115, maintaining consistency with other projects.
Also applies to: 31-33, 37-39, 43-45, 49-51, 175-177
nanoFramework.Fire/packages.lock.json (1)
37-39
: LGTM! Consistent version updates across dependencies.All IoT Device dependencies have been updated to version 1.2.737 and Nerdbank.GitVersioning to 3.7.115, maintaining consistency with other projects.
Also applies to: 43-45, 49-51, 55-57, 61-63, 67-69, 187-189
nanoFramework.M5Core2/packages.lock.json (2)
199-201
: Build Tool Update Looks Good!The Nerdbank.GitVersioning tool has been updated to version 3.7.115, which is a minor version bump focusing on build improvements.
Line range hint
31-69
: IoT Device Package Updates Look Good!The IoT device packages have been consistently updated to version 1.2.737, which aligns with the PR objectives. This coordinated update ensures compatibility between the IoT device packages.
Let's verify that all IoT device packages are on the same version:
Bumps nanoFramework.Iot.Device.Button from 1.2.718 to 1.2.737
Bumps nanoFramework.Iot.Device.Ws28xx.Esp32 from 1.2.696 to 1.2.737
Bumps Nerdbank.GitVersioning from 3.7.112 to 3.7.115
Bumps nanoFramework.Iot.Device.Mpu6886 from 1.2.718 to 1.2.737
Bumps nanoFramework.Iot.Device.Buzzer from 1.2.718 to 1.2.737
Bumps nanoFramework.Iot.Device.ePaper from 1.0.558 to 1.0.573
Bumps nanoFramework.Iot.Device.Rtc from 1.2.718 to 1.2.737
Bumps nanoFramework.Iot.Device.Bmm150 from 1.2.704 to 1.2.737
Bumps nanoFramework.Iot.Device.Ip5306 from 1.2.718 to 1.2.737
Bumps nanoFramework.Iot.Device.Axp192 from 1.2.718 to 1.2.737
Bumps nanoFramework.Iot.Device.Chsc6540 from 1.1.696 to 1.1.737
[version update]
Summary by CodeRabbit
1.2.718
to1.2.737
Nerdbank.GitVersioning
updated from3.7.112
to3.7.115