Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k8s example #180

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Fix k8s example #180

merged 4 commits into from
Oct 8, 2024

Conversation

itspluxstahre
Copy link
Contributor

Fixed the yaml formatting of the k8s example and also added an example for an PVC.

Fix formatting of yaml example.
Add back the explanation comments.
Add an PVC example.
Copy link
Owner

@nanos nanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @itspluxstahre ! Really appreciate you taking the time to contribute to this!

Unfortunately I don't really know k8s, so I'm asking a couple of questions for clarification, to ensure these changes weren't accidental. Can you clarify please?

Thanks!

examples/k8s-cronjob.md Show resolved Hide resolved
examples/k8s-cronjob.md Show resolved Hide resolved
@itspluxstahre
Copy link
Contributor Author

Thanks for your PR @itspluxstahre ! Really appreciate you taking the time to contribute to this!

Unfortunately I don't really know k8s, so I'm asking a couple of questions for clarification, to ensure these changes weren't accidental. Can you clarify please?

Thanks!

Thanks for the feedback, I will doublecheck these later today and clarify if needed or update the PR. :)

@nanos
Copy link
Owner

nanos commented Oct 4, 2024

Hey @itspluxstahre just wondering if you’ve had a chance to look into this? No rush of course but just wanted to make sure it isn’t forgotten.

Thanks.

Readd a couple of options that was removed temporarily for testing
@itspluxstahre
Copy link
Contributor Author

Hey @itspluxstahre just wondering if you’ve had a chance to look into this? No rush of course but just wanted to make sure it isn’t forgotten.

Thanks.

Yep, added them back. My misstake I copied stuff from my deployment for my own cluster that contains stuff that would be confusing in an example like this.

@nanos
Copy link
Owner

nanos commented Oct 8, 2024

Thanks @itspluxstahre

@nanos nanos merged commit 0dfac70 into nanos:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants