-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix k8s example #180
Fix k8s example #180
Conversation
Fix formatting of yaml example.
Add back the explanation comments.
Add an PVC example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @itspluxstahre ! Really appreciate you taking the time to contribute to this!
Unfortunately I don't really know k8s, so I'm asking a couple of questions for clarification, to ensure these changes weren't accidental. Can you clarify please?
Thanks!
Thanks for the feedback, I will doublecheck these later today and clarify if needed or update the PR. :) |
Hey @itspluxstahre just wondering if you’ve had a chance to look into this? No rush of course but just wanted to make sure it isn’t forgotten. Thanks. |
Readd a couple of options that was removed temporarily for testing
Yep, added them back. My misstake I copied stuff from my deployment for my own cluster that contains stuff that would be confusing in an example like this. |
Thanks @itspluxstahre |
Fixed the yaml formatting of the k8s example and also added an example for an PVC.