Skip to content

Commit

Permalink
fix broken test and reviewdog
Browse files Browse the repository at this point in the history
  • Loading branch information
nao1215 committed Dec 31, 2023
1 parent 21b942e commit 48bf68a
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 27 deletions.
3 changes: 2 additions & 1 deletion .gitleaksignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
389697647cbf4df63a2d2949f648216025355763:localstack/cache/server.test.pem.key:private-key:1
389697647cbf4df63a2d2949f648216025355763:localstack/cache/server.test.pem:private-key:1
389697647cbf4df63a2d2949f648216025355763:localstack/cache/server.test.pem:private-key:1
21b942e8aebe04827785fe961d4c97fb8323f7ba:doc/spare/README.md:generic-api-key:68
25 changes: 0 additions & 25 deletions app/external/common.go

This file was deleted.

2 changes: 1 addition & 1 deletion config/spare/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type Config struct {
// If you do not specify this, the CloudFront default domain name is used.
CustomDomain model.Domain `yaml:"customDomain"`
// S3Bucket is the name of the S3 bucket.
S3Bucket model.Bucket `yaml:"s3BucketName"`
S3Bucket model.Bucket `yaml:"s3BucketName"` //nolint
// AllowOrigins is the list of domains that are allowed to access the SPA.
AllowOrigins model.AllowOrigins `yaml:"allowOrigins"`
DebugLocalstackEndpoint model.Endpoint `yaml:"debugLocalstackEndpoint"`
Expand Down
7 changes: 7 additions & 0 deletions config/spare/testdata/read_test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
spareTemplateVersion: 1.0.0
deployTarget: test-src
region: us-east-2
customDomain: "example.com"
s3BucketName: "test-bucket"
allowOrigins: ["example.com", "test.example.com"]
debugLocalstackEndpoint: http://localhost:4566
7 changes: 7 additions & 0 deletions config/spare/testdata/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
spareTemplateVersion: 0.0.1
deployTarget: src
region: us-east-1
customDomain: ""
s3BucketName: ""
allowOrigins: []
debugLocalstackEndpoint: http://localhost:4566
7 changes: 7 additions & 0 deletions config/spare/testdata/test_windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
spareTemplateVersion: 0.0.1
deployTarget: src
region: us-east-1
customDomain: ""
s3BucketName: ""
allowOrigins: []
debugLocalstackEndpoint: http://localhost:4566

0 comments on commit 48bf68a

Please sign in to comment.