Fix pogress bar bug and upload s3 object bug

[nao1215]

Summary by CodeRabbit

• New Features
  • Enhanced the deletion functionality for S3 objects to support removing all versions when bucket versioning is enabled.
• Bug Fixes
  • Improved content type detection for S3 objects by ensuring buffer integrity.
• Refactor
  • Standardized naming from S3ObjectSets to S3ObjectIdentifiers across various components to improve code clarity.
  • Refined logic for bucket deletion and object listing in the UI for better progress tracking and status updates.

[coderabbitai]

Walkthrough

The recent update enhances the handling of S3 objects, particularly improving content type detection and deletion operations. A notable change is the creation of a buffer copy for safer content type detection, and the extension of the DeleteS3Objects method to support the deletion of all versions of objects in versioned buckets. Additionally, there's a consistent renaming of the S3ObjectSets field to S3ObjectIdentifiers across various components to better reflect its purpose.

Changes

File Path	Change Summary
app/domain/model/s3.go	Updated ContentType method to create a buffer copy before detecting content type.
app/external/s3.go	Enhanced DeleteS3Objects to delete all versions in versioned buckets.
app/interactor/s3.go app/interactor/s3_test.go app/usecase/s3.go cmd/subcmd/s3hub/rm.go ui/s3hub/command.go	Renamed S3ObjectSets to S3ObjectIdentifiers.
ui/s3hub/delete.go ui/s3hub/list.go	Adjusted logic for bucket deletion and progress tracking.

🐇✨
In the world of bytes and buckets wide,
A change was made with care and pride.
Objects renamed, and safely deleted,
By a rabbit's touch, tasks completed.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[github-actions]

HOTTEST report

PASS	FAIL	SKIP	TOTAL	DURATION
283	0	7	290	5.499933048s

---

Reported by hottest

[github-actions]

Code Metrics Report

	main (fb9a2db)	#53 (71bdfb5)	+/-
Coverage	24.7%	24.6%	-0.1%
Test Execution Time	8s	14s	+6s

Details

  |                     | main (fb9a2db) | #53 (71bdfb5) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          24.7% |         24.6% | -0.1% |
  |   Files             |             42 |            42 |     0 |
  |   Lines             |           1606 |          1619 |   +13 |
+ |   Covered           |            396 |           398 |    +2 |
- | Test Execution Time |             8s |           14s |   +6s |

Code coverage of files in pull request scope (25.6% → 25.4%)

Files	Coverage	+/-
app/domain/model/s3.go	99.0%	+0.0%
app/external/s3.go	41.9%	0.0%
app/interactor/s3.go	100.0%	0.0%
cmd/subcmd/s3hub/rm.go	0.0%	0.0%
ui/s3hub/command.go	0.0%	0.0%
ui/s3hub/delete.go	0.0%	0.0%
ui/s3hub/list.go	0.0%	0.0%

---

Reported by octocov

[coderabbitai]

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between fb9a2db and 56c46eb.

Files selected for processing (9)

• app/domain/model/s3.go (1 hunks)
• app/external/s3.go (1 hunks)
• app/interactor/s3.go (1 hunks)
• app/interactor/s3_test.go (3 hunks)
• app/usecase/s3.go (1 hunks)
• cmd/subcmd/s3hub/rm.go (2 hunks)
• ui/s3hub/command.go (2 hunks)
• ui/s3hub/delete.go (4 hunks)
• ui/s3hub/list.go (9 hunks)

Additional comments: 21

app/usecase/s3.go (1)

• 75-76: The field S3ObjectSets has been correctly renamed to S3ObjectIdentifiers to improve clarity and consistency across the application.

cmd/subcmd/s3hub/rm.go (2)

• 139-139: The field S3ObjectSets has been correctly renamed to S3ObjectIdentifiers in the removeObject function, aligning with the renaming effort across the application for clarity.
• 178-179: The field S3ObjectSets has been correctly renamed to S3ObjectIdentifiers in the removeObjects function, maintaining consistency with the renaming effort across the application.

ui/s3hub/delete.go (4)

• 117-119: The logic for handling bucket deletion and progress tracking in the Update method has been adjusted. Ensure that the change from initializing m.index from 0 to 1 does not conflict with the intended progress tracking behavior, especially considering previous implementations.
• 139-139: Initialization of m.index to 1 in the Update method of s3hubDeleteBucketModel struct. Verify this change aligns with the intended progress tracking behavior, considering previous implementations where m.index was initialized to 0.

Verification successful

---

The grep command output indicates that the initialization of m.index to 1 is consistent across multiple files within the ui/s3hub directory, specifically in both delete.go and list.go. This consistency suggests that the initialization of m.index to 1 is a deliberate design choice for operations within the s3hub UI components, likely intended to align with a specific progress tracking or indexing behavior that starts from 1 rather than 0. Given this context, the change in the Update method of the s3hubDeleteBucketModel struct to initialize m.index to 1 aligns with similar operations in the codebase, indicating that the review comment concern has been addressed by the evidence of consistent implementation across related components.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Verify the initialization of m.index across similar operations to ensure consistency.
grep -R "m.index = " ui/

Length of output: 193

* 161-165: Adjustment to the handling of bucket deletion completion in the `Update` method. Ensure this change correctly updates the status and displays a message for each deleted bucket, improving clarity for the user. * 171-171: Modification to the message displayed when the bucket list is empty for clarity. This change enhances user understanding when no buckets are available for deletion.

ui/s3hub/command.go (2)

• 220-221: In the deleteS3BucketCmd function, the change from S3ObjectSets to S3ObjectIdentifiers correctly reflects the renaming effort for clarity and consistency across the application.
• 278-278: In the deleteS3ObjectCmd function, the change from S3ObjectSets to S3ObjectIdentifiers aligns with the renaming effort, ensuring clarity in the codebase.

app/external/s3.go (1)

• 217-217: Added functionality in DeleteS3Objects method to handle deletion of all versions of specified objects when bucket versioning is enabled. This enhancement addresses the complexities of managing objects in versioned S3 buckets, ensuring that all versions of an object can be effectively removed.

app/interactor/s3.go (1)

• 180-180: The field name S3ObjectSets has been correctly updated to S3ObjectIdentifiers to match the renaming effort across the application for clarity.

app/domain/model/s3.go (1)

• 449-453: Creating a copy of the buffer before detecting the content type is a good practice to avoid consuming the original buffer, which is necessary for operations that need to read the buffer again.

ui/s3hub/list.go (6)

• 118-120: Adding conditions for returning early in certain status states improves control flow and user experience by preventing unnecessary actions based on the current status.
• 182-186: The logic for handling the completion of bucket downloads and updating the progress tracking is well-implemented, ensuring that the user is informed of each completed download.
• 195-199: The logic for handling the completion of bucket deletions and updating the progress tracking is correctly implemented, providing clear feedback to the user on the operation's progress.
• 436-438: Adding conditions for returning early in certain status states in the s3hubListS3ObjectModel function is a good practice for managing control flow based on the operation's current status.
• 494-498: The logic for handling the completion of S3 object downloads and updating the progress tracking is correctly implemented, ensuring that the user is informed of each completed download.
• 507-511: The logic for handling the completion of S3 object deletions and updating the progress tracking is well-implemented, providing clear feedback to the user on the operation's progress.

app/interactor/s3_test.go (3)

• 379-379: The field S3ObjectSets in the S3ObjectsDeleterInput struct has been correctly renamed to S3ObjectIdentifiers to match the updated naming convention. This change aligns with the PR objectives and improves clarity.
• 419-419: The field S3ObjectSets in the S3ObjectsDeleterInput struct has been correctly renamed to S3ObjectIdentifiers to match the updated naming convention. This change aligns with the PR objectives and improves clarity.
• 448-448: The field S3ObjectSets in the S3ObjectsDeleterInput struct has been correctly renamed to S3ObjectIdentifiers to match the updated naming convention. This change aligns with the PR objectives and improves clarity.