-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] switch to ruff, per napari/napari #199
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 86.02% 85.90% -0.12%
==========================================
Files 26 24 -2
Lines 1073 1043 -30
==========================================
- Hits 923 896 -27
+ Misses 150 147 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Since the ruff CI test is passing, I say go ahead and merge.
Great, thank you for this @psobolewskiPhD 🎉 |
Just to make life easier, switching this repo to also use ruff like napari/napari, instead of flake8 and isort.
Also dropped some old Conda cruft from tox.ini which wasn't used.
After making the tooling changes, I also ran ruff and made various fixes to get everything to pass.