Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] switch to ruff, per napari/napari #199

Merged
merged 11 commits into from
Jan 15, 2024

Conversation

psobolewskiPhD
Copy link
Member

@psobolewskiPhD psobolewskiPhD commented Jan 12, 2024

Just to make life easier, switching this repo to also use ruff like napari/napari, instead of flake8 and isort.
Also dropped some old Conda cruft from tox.ini which wasn't used.

After making the tooling changes, I also ran ruff and made various fixes to get everything to pass.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3d45bd5) 86.02% compared to head (b2a89ce) 85.90%.

Files Patch % Lines
napari_animation/_qt/savedialog_widget.py 0.00% 1 Missing ⚠️
napari_animation/viewer_state.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   86.02%   85.90%   -0.12%     
==========================================
  Files          26       24       -2     
  Lines        1073     1043      -30     
==========================================
- Hits          923      896      -27     
+ Misses        150      147       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@GenevieveBuckley GenevieveBuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
Since the ruff CI test is passing, I say go ahead and merge.

@GenevieveBuckley GenevieveBuckley merged commit 521d0b3 into napari:main Jan 15, 2024
16 checks passed
@GenevieveBuckley
Copy link
Contributor

Great, thank you for this @psobolewskiPhD 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants