Add Logging Statements and Avoid Crash #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a pair of logging statements to
format_alignment
. I thought it was worth alerting the user if an invalid column type was passed in.The second commit avoids a crash if the script is passed an empty file (or if
skip
is large enough to skip all of the rows in a file). Compare the output ofbefore and after the commit. One possible solution (the route I took) is to initialize
num_columns
to zero and then modifyformat_alignment
to avoid an empty return value (which would cause a TeX error) whenlength
is zero. If you'd like to handle it in another way you can skip this commit.