fix: if user is deleted, show ghost (#26)

narwhal-apps · Oct 4, 2024 · 7bdbcb7 · 7bdbcb7
1 parent 24b2c61
commit 7bdbcb7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/components/Reviews.svelte b/src/components/Reviews.svelte
@@ -17,12 +17,16 @@
     $github.fetchReviews($auth.account, $auth.githubSettings);
     dateUpdater++;
     const ele = document.getElementById('reviews');
-    setWindowSize(ele.clientHeight);
+    if (ele) {
+      setWindowSize(ele.clientHeight);
+    }
   }, $auth.settings.fetchInterval || defaultSettings.fetchInterval);
 
   const onLoad = (ele: Element) => {
     setTimeout(() => {
-      setWindowSize(ele.clientHeight);
+      if (ele) {
+        setWindowSize(ele.clientHeight);
+      }
     }, 100);
   };
 
@@ -144,7 +148,7 @@
                 <div class="flex flex-row items-center gap-1">
                   {#key dateUpdater}
                     <span class="text-sm text-gray-500 truncate dark:text-gray-400">
-                      {timeAgo(review.node.createdAt)} by @{review.node.author.login}
+                      {timeAgo(review.node.createdAt)} by @{review.node.author?.login || 'ghost'}
                     </span>
                   {/key}
                   <span

diff --git a/src/lib/window-size.ts b/src/lib/window-size.ts
@@ -2,7 +2,7 @@ import { appWindow, LogicalSize } from '@tauri-apps/api/window';
 const DEFAULT_HEIGHT = 400;
 const DEFAULT_WIDTH = 500;
 const FOOTER_HEIGHT = 56;
-const MIN_HEIGHT = 100;
+const MIN_HEIGHT = 120;
 
 export const resetWindowSize = async () => await appWindow.setSize(new LogicalSize(DEFAULT_WIDTH, DEFAULT_HEIGHT));